psalm icon indicating copy to clipboard operation
psalm copied to clipboard

Published 20 hours ago • verified publisher icon vimeo

Fix condition literal-string is non-empty-string

Open VincentLanglet opened this issue 2 months ago • 2 comments

Hi @orklah, this PR is similar to https://github.com/vimeo/psalm/pull/10912

Closes https://github.com/vimeo/psalm/issues/10926

VincentLanglet avatar Apr 28 '24 22:04 VincentLanglet

The only error I get now is coming from the test https://github.com/vimeo/psalm/pull/10927/files/91ea61e4170656cb7a54347271d054e9037106d6#diff-19d1ea03f9fa43528c7190e1c91a6a4f216c48b742e3e2dcdd4e75e750c6a7a5

But this failure also happen in 5.x as soon as I fix the phpdoc of the tests https://github.com/vimeo/psalm/pull/10929 I search a long time and dunno why psalm is failing to get the right type.

Should I comment the test in a separate PR @orklah since the test is wrong as shown by https://github.com/vimeo/psalm/pull/10929 ?

VincentLanglet avatar Apr 29 '24 17:04 VincentLanglet