Viktor Hofer
Viktor Hofer
> VS test does not work for the inner loop if you work on the core runtime, for the reasons mentioned above. Command line only. FWIW, VS Test Explorer which...
Without fixing this, source building dotnet/runtime and other repos that depend on affected tools will be broken so we should prioritize it correctly.
Why does source build not work with the current LTS which is `netcoreapp3.1`? Aside from that, shouldn't Arcade just upgrade all dependencies to net6.0 so that we have a consistent...
> It is a blocker for source build. The goal is to be able to have a source-build tarball available for preview 6. As some repos already snapped for Preview...
We don't have a blocking label, right? Wanted to add one as even though this issue is open since May, it's still blocking sourcebuild to produce 6.0 bits. > Yes...
> If you are already adding patches Correct me if I'm wrong but source build doesn't use patches anymore, at least not in dotnet/runtime and other repos that I'm following....
This would have helped source build but presumably no one wants to do it. @dseefeld is there a mitigation process in place to avoid the mentioned issue?
Sorry was on holiday. Correct, corefx has sourcelink enabled in all customer facing assemblies.
@smasher164 can you please update the changes in the newly added rule according to our official [C# Coding Conventions](https://github.com/dotnet/sdk/pull/26891)? (method casing, naming conventions, ...) Doing so makes reviewing these changes...
@smasher164 are you currently filtering out attributes that aren't visible outside? See https://github.com/dotnet/arcade/blob/3dd26504b456b68c2e3edd18ebf159d0b5486135/src/Microsoft.Cci.Extensions/Filters/PublicOnlyCciFilter.cs#L72-L94. That is the attribute filter implementation in the old APICompat. To summarize what it does: 1. It...