Viktor Hofer comments

Results 314 comments of


                                            Viktor Hofer

source-build: support building runtime using non-portable runtime packages.

Closing and reopening usually does the trick and retriggers all the legs.

source-build: support building runtime using non-portable runtime packages.

Added a style nit commit. Also, to retrigger CI as there were more than 20 failing legs.

source-build: support building runtime using non-portable runtime packages.

Thanks a lot, Tom!

remove explicit LangVersion from a few projects

This one can be removed as well: https://github.com/dotnet/runtime/blob/16cb35fda05165d679603c1c9c7ca5710e9bd3df/src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj#L10

remove explicit LangVersion from a few projects

As explained [here](https://github.com/dotnet/runtime/pull/75168#discussion_r967084597) it can be removed now.

remove explicit LangVersion from a few projects

Thanks a lot. Great work!

remove explicit LangVersion from a few projects

Thanks a lot

System.IO.FileNotFoundException thrown when using System.Text.Json in mixed .Net version solution. Assembly versions do not match.

> Here's a sample: https://github.com/ericstj/sample-code/tree/netfx-library-reuse. @ericstj With `ExcludeAssets="all"` on the `System.Text.Json` PackageReference, will the msbuild files under buildTransitive and the analyzer files under `analyzers` still be picked up? Asking as...

Tests failures: System.Net.NameResolution.Tests / DnsObsolete* & Dns_GetHostEntry*

A bunch of NameResolution tests failed again (including the ones mentioned in this issue): https://dnceng.visualstudio.com/public/_build/results?buildId=525372&view=ms.vss-test-web.build-test-results-tab&runId=16621996&resultId=137716&paneView=debug @wfurt @davish suggestions for mitigation?

Tests failures: System.Net.NameResolution.Tests / DnsObsolete* & Dns_GetHostEntry*

What about leveraging the `RetryHelper` for DNS tests which are inherently flaky?