feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Link to source from API docs

Open LindaLawton opened this issue 6 years ago • 21 comments

Is your feature request related to a problem? Please describe. It would be nice if documentation pages like microsoft.aspnetcore.authentication.authenticationservice.challengeasync linked to their respscitve GitHub source pages for example AuthenticationService.cs or at the very least link to the class or the project it self.

Describe the solution you'd like I find the documentation pages lacking in what these methods actually do so find myself often checking the source code in order to understand whats going on. Having to search for the the GitHub project can be time consuming. It would be nice to have a link on the page.

Describe alternatives you've considered

  1. Just a link to the project
  2. a link to the class itself.
  3. A link to the method in question.

Additional context

Examples on these pages would be really nice rather than just a blank description of the method. I realize that i am asking for a lot.

LindaLawton avatar Jun 13 '18 12:06 LindaLawton

@LindaLawton Thanks for your suggestion. I've created a internal work item to track your request. I will let you know when we have solution on it.

Powerhelmsman avatar Jun 13 '18 16:06 Powerhelmsman

#log-suggestion @dend

Powerhelmsman avatar Jun 13 '18 16:06 Powerhelmsman

🚀 ATTENTION: Internal request logged.

supernova-eng avatar Jun 13 '18 16:06 supernova-eng

@dend should we change the title of this issue to say Link to source from API docs or something like that?

mairaw avatar Jul 12 '18 22:07 mairaw

@mairaw yes, I updated the title, thanks for the heads-up!

dend avatar Jul 12 '18 22:07 dend

Hi folks, we've assessed this feature request and have determined that we will not be able to address it at this time.

Our documentation is generated entirely from binaries (shipped in DLLs and NuGet packages), therefore there is no direct link to the source code of the product that we can re-use for the purposes of including it in our documentation. More-so, we span different versions, so while the source code is available for some, it is not for others, which will create an inconsistency in the experience.

We do have on our radar the task to implement changes that will make it easier for customers to see what NuGet package things are coming from (see #72).

dend avatar Aug 07 '18 22:08 dend

Thank you for your consideration.

LindaLawton avatar Aug 07 '18 23:08 LindaLawton

@dend I'd very much like you to reconsider.

For the repos that stamp their binaries using SourceLink, generating a link to the source from a built product is possible. This is essentially what Visual Studio now does when debugging into NuGet or framework assemblies.

This would be a very great and useful feature and could work for any API docs for products using SourceLink.

I often use this for things like NumPy when I need to look up various implementations: image

dasMulli avatar Jul 31 '19 08:07 dasMulli

@ViktorHofer from what I unserstand, CoreFX now also has SourceLink via Arcade?

dasMulli avatar Jul 31 '19 08:07 dasMulli

Sorry was on holiday. Correct, corefx has sourcelink enabled in all customer facing assemblies.

ViktorHofer avatar Aug 06 '19 23:08 ViktorHofer

@docs-product @mimig1 please look at the latest comments.

mairaw avatar Sep 18 '19 18:09 mairaw

@mairaw - Should this go to @mimisasouvanh?

mimig1 avatar Sep 18 '19 19:09 mimig1

Apologies @mimig1 for tagging the wrong Mimi.

@BillWagner @gewarren This is related to the questions we got during our meeting today. I think we should resume this conversation again.

mairaw avatar Jul 24 '20 01:07 mairaw

Mimi logged an internal issue for this in June.

gewarren avatar Jul 24 '20 16:07 gewarren

Hello - reviewing and cleaning up some older feedback/issues. Thanks!

keziamicro avatar Mar 17 '21 22:03 keziamicro

@gewarren @keziamicro Is the internal issue closed / not further developed? Can at least 1 (this) issue stay open publicly so we know the issue is still being tracked / worked on? Because many people (including me) keep opening issues about this. My issue was closed in favor of this issue (which was reopened). But now this issue is also closed again.

Related (duplicate) issues: #2800, #2947, #157, #3099, #3416

synercoder avatar Aug 11 '21 11:08 synercoder

@synercoder I am still here and i still think this would be a valuable addition. Just yesterday i went digging round in AddMicrosoftIdentityWebApi I still had to find the link to the source myself.

As for the Developers we realize that somethings are hard to add after the fact keep thinking about it maybe something will come up one day. See you in another three years.

LindaLawton avatar Aug 11 '21 12:08 LindaLawton

@keziamicro Okay to keep this open until the internal work item reaches resolution? That one is still open but work has not commenced.

gewarren avatar Aug 11 '21 15:08 gewarren

I was about to open my own issue for this same feature request before I found this one. It looks like there have been no MS updates since at least August of last year. Has anything changed on the Microsoft end at this point?

emagers avatar Apr 07 '22 15:04 emagers

@emagers Yes, there has been recent activity on the internal work item. We are hoping to come up with a solution to this common request.

gewarren avatar Apr 07 '22 18:04 gewarren

Well I'm still here and I still think it would be a valid addition.

Thank you for your consideration.

LindaLawton avatar Apr 09 '22 16:04 LindaLawton

Great news - the core .NET libraries now have links to source code! The ASP.NET Core API docs should be updated soon. Example: https://learn.microsoft.com/en-us/dotnet/api/system.string.chars?view=net-8.0

image

gewarren avatar Apr 04 '24 17:04 gewarren

This is really awesome news, thanks to everyone for making it happen!

emagers avatar Apr 04 '24 17:04 emagers

Now that the ASP.NET Core reference docs have source links too, I'm going to close this issue.

gewarren avatar Apr 09 '24 21:04 gewarren