Viktor Hofer

Results 314 comments of Viktor Hofer

I'm currently looking into using NuGet's Central Package Management in dotnet/runtime and I'm now at a point where I understand all the changes that we would need from Darc/Maestro so...

See my comment in https://github.com/dotnet/arcade-services/pull/1892#issuecomment-1126495688. > I'd also like to make sure expectations are understood here. We currently don't have plans to support this in maestro during the .NET 7...

@kasperk81 release/7.0 already updated the SDK to RC1 so it's probably best to apply those changes (in order / or manually): - https://github.com/dotnet/arcade/commit/72ccf7f136ef29fcdc6d7138788876f0dec0cd68 - https://github.com/dotnet/arcade/commit/720af493900b2f2bdc48e9ee12577983a5c9be36

See the second commit that I linked to which then updates the SDK to the publicly shipping one: https://github.com/dotnet/arcade/commit/720af493900b2f2bdc48e9ee12577983a5c9be36#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bfR3. That one should be used, yes. That's why I mentioned that...

APICompat changes look good to me. There are a ton of conflicts though.

The target date for this is October 10th, to make sure that documentation is in place when RC2 releases publicly.

It's recommended to use a third party library according to the docs: https://docs.microsoft.com/en-us/dotnet/core/compatibility/networking/6.0/webrequest-deprecated#recommended-action.

According to the title, the public key token might be missing or the author omitted it intentionally. We would need a binlog or a verbose log to make this more...

Just stumbled upon this. > I don't know the reasons for the guid but I would rather avoid yet another option. I disagree. VSTest should respect the specified `ResultsDirectory` and...