Max Gautier

Results 799 comments of Max Gautier

I think widening the version support is acceptable, as long as it does not introduce too much overhead in kubespray itself (i.e, it is possible to support 2.17 and 2.19...

> Sorry for the late reply (I changed my job in the past weeks.) Congrats 🎉 (well, I guess ?)

That would need a proper release-note, as a new feature.

You'll need to rebase on master, the pipelines definitions have changed.

We should mention in the release-note that the node affinity is removed, and this might actually warrants an action required, I could see users relying on the coredns pods scheduled...

Sorry my comment was not explicit : you should add the string 'action required' somewhere in the release-note (does not matter where, on a first line on its own is...

This still needs a rebase :)

Yeah but I don't think we actually run it in PR jobs, do we ?