Max Gautier

Note: I think node labels removal should work with SSA (unlike taints :/ ) so that we only remove the labels we applied and not some applied by other controllers...

SSA is server side apply, sorry for the acronym. So it's not about previously declared labels then. I'm not sure we should interfere with other client labeling the nodes ;...

https://github.com/kubernetes-sigs/kubespray/pull/12768#issuecomment-3622458384 Agree to that, there is not really a reason to separate the two

I think you're referring to c1c52002cfcc5006e8e194ce408cf82963bc5ef7 (the hash you linked is not in this repository) but this one is just the removal of the variables, not of the functionality in...

The thing is, this does not remove the default filter (and such case with hostvars can be a acceptable usage, as there is no way to access defaults/vars through hostvars...

I haven't seen any egregious regression in the issues or PR, so good for me. I'll shout if I see anything, as I'm reviewing while waiting for my control plane...

IMO we should avoid backporting the CSI stuff: - it's not a regression in 2.29.0 - major version bump.

Also note, #12227 is relevant here. Once kubespray is only packaged as a collection, we can drop the ansible requirements and instead rely on the relevant ansible-core version. This is...

Btw, why exactly do you want to keep the number of venv low ? It's pretty standard to have one per-project.

Not really, honnestly, it's not like venv are expensive 🤔. Anyway, widening the version range (aka, still keeping support for old versions) is not necessarily a bad thing, as long...