Max Gautier
Max Gautier
> Therefore, would it be more reasonable to remove pyyaml from the Helm installation process? > > Do you mind share your thoughts, @tico88612 @VannTen. :-) My opinion is that...
On the other for the short term, installing packages should probably go in system_packages even if the `package` modules is not usable, and use the same filtering logic as the...
What I mean by moving to `system_packages` was to reuse the `pkgs` variables, but consume it in a different task, which would mirror the one using `package` using `rpm_ostree_pkg` instead...
At this point can't we just have a values-overrides thing which we'd feed directly to cilium cli ?
I don't understand why we'd need this when we already have `cilium_extra_values`. Isn't that enough to pass stuff to cilium-cli ?
The fact that one variable exists is not justification enough to add another one. Is there a dependency between the two ? (as in, the value of one depend on...
> wouldn't it make more sense to pre-calculate these values in a separate task like this? It's probably better to put it in the role vars/ folders instead. (set_fact is...
The config extra vars stuff is passed as a second values files to ciliumcli right ? In that case you don't need to check it in the default value, since...
Yeah, eschew the variables, the indirection only adds complexity for a simple expression like this.
This seems sane to me, but I'm not deep in cilium. @tico88612 changes makes sense to you ?