Sagirov Evgeniy
Sagirov Evgeniy
@bmtcril Should I add a migration in this PR or add skip for this test and add a migration separately?
@ormsbee I've opened a separate pull request with the straightforward tests: https://github.com/openedx/edx-platform/pull/31224 This pr includes some of tests that have been commented on about `ddt`, it's fixed.
@abdullahwaheed Could you provide the patch file please?
@abdullahwaheed yes, sure. I rebased this PR and resolved conflicts. Files affected: `lms/djangoapps/discussion/views.py` and `common/djangoapps/Third_Party_auth/tests/specs/base.py`.
Hi @bmtcril , thank you. I've rebased PR's, there were no conflicts.
@connorhaugh This PR is ready for review, take a look please)
@mphilbrick211 Hi! I'll rebased it after merging this PR https://github.com/openedx/edx-platform/pull/31480
@ormsbee @mphilbrick211 PR rebased
@ormsbee I addressed all comments except last one. I left a question to your comment: > Can we mock the data at the Mongo layer–i.e. exercise Old Mongo read logic...
@ormsbee we are not found any test that regenerate course overview, so we planning add a new one. If it's possible to regenerate course overview we will follow you advice.