FC-0001: ecommerce Basket Page -> micro-frontend

[UvgenGen]

Description

According to this documentation i prepared first part with migration making the enable_microfrontend_for_basket_page column nullable. This PR should be merged after that one https://github.com/openedx/ecommerce/pull/3829

Removing ecommerce's older implementation of the Django-server-side rendering of the Basket Page.

Replacing the Basket page with a new micro-frontend-based implementation: edx/frontend-app-payment

Updated the model and generated a migration making the column nullable (null=True) (https://github.com/openedx/ecommerce/pull/3829) Updated SiteConfiguration model: removed enable_microfrontend_for_basket_page field. (always redirects to the MFE now). Removed views and templates for Django-server-side Basket Page. Updated tests.

Supporting information

https://github.com/openedx/public-engineering/issues/68 Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-42

PR to edx-platform: https://github.com/openedx/edx-platform/pull/30377 PR with migration making the enable_microfrontend_for_basket_page column nullable: https://github.com/openedx/ecommerce/pull/3829

[openedx-webhooks]

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[natabene]

Let's see how tests turn out.

[bmtcril]

Hi @UvgenGen sorry for the delay on this, I can help you get these merged. The direction looks good to me. Can you rebase this one and the edx-platform counterpart and fix up any conflicts? Once the tests are passing I can help get it over the line.

[UvgenGen]

Hi @bmtcril , thank you. I've rebased PR's, there were no conflicts.

[bmtcril]

Hi @openedx/ecommerce-maintainers ! I've pinged you for review on these PRs, but can't ping you on the associated edx-platform one. I talked to Seth about them, so hopefully it's not a total surprise. I believe that we can do them in the order of:

1- edx-platform (https://github.com/openedx/edx-platform/pull/30377) 2- The other ecomm one, which I don't have handy but is just the first step of the migration dance needed for this one to land 3- This one

My biggest remaining concern with these is that the Basket MFE is up to feature parity with the functionality being removed. Can anyone confirm that on your side?

[colinbrash]

Hello Brian!

@UvgenGen @bmtcril

I have a couple requests:

1. The PR descriptions and commit messages have very little information about what changes are intended. Would you please you add more details about what the code changes actually are doing? For example, I see some discussion in a code change comment about a migration, but this is not mentioned in the Description!
2. In addition to what the changes are, it would be helpful to understand what risks there are to merging. Again, sounds like there are risks mentioned in comments, but not described in the Description.
3. We are in the middle of some time-sensitive, critical work and it will be difficult to review these PRs before we are finished (approx. 30 days or so). I'd like to understand the urgency and the dependencies between the PRs.
   1. Do these need to be merged by a particular date (e.g. is it an issue if we begin review in a month)? (cc @dianakhuang)
   2. Do we need to coordinate merging them on a particular schedule? Or as long as they are done in order, can they be merged on independent timelines?

Thanks!

[UvgenGen]

@colinbrash Hi! I've updated the description and commit message.

[UvgenGen]

description for the first part updated to https://github.com/openedx/ecommerce/pull/3829.