edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

FC-0001: Account pages -> micro-frontend

Open UvgenGen opened this issue 2 years ago • 6 comments

NOTE: Don't merge

Merge after the Olive release.

Description

replaced edx-platform's older implementation of the Django-server-side rendering of the following pages with new micro-frontend-based implementations:

PR to frontend-platform: https://github.com/openedx/frontend-platform/pull/326 PR to frontend-component-header: https://github.com/openedx/frontend-component-header/pull/210

Supporting information

https://github.com/openedx/public-engineering/issues/71 Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17

UvgenGen avatar May 02 '22 14:05 UvgenGen

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar May 02 '22 14:05 openedx-webhooks

@dianakhuang This seems to be with arch-bom, do you mind reviewing and merging?

natabene avatar May 03 '22 20:05 natabene

@UvgenGen i have reviewed and tested your changes and resolved merge conflicts locally. I cannot push my changes in your forked repo. Please either give me write access to your repo or i'll provide the patch file for changes.

abdullahwaheed avatar Oct 17 '22 09:10 abdullahwaheed

@abdullahwaheed Could you provide the patch file please?

UvgenGen avatar Oct 17 '22 09:10 UvgenGen

@UvgenGen the patch couldn't created for all the commits as i have merged it with master and resolved conflicts only. Could you please rebase it with master and i'll help you resolve the conflicts

abdullahwaheed avatar Oct 17 '22 14:10 abdullahwaheed

@abdullahwaheed yes, sure. I rebased this PR and resolved conflicts. Files affected: lms/djangoapps/discussion/views.py and common/djangoapps/Third_Party_auth/tests/specs/base.py.

UvgenGen avatar Oct 17 '22 14:10 UvgenGen

@UvgenGen could you please rebase it again

abdullahwaheed avatar Jan 12 '23 13:01 abdullahwaheed

@abdullahwaheed PR rebased)

UvgenGen avatar Jan 16 '23 18:01 UvgenGen

@UvgenGen should the name of this PR be updated? We're after olive, can this now be merged?

e0d avatar Jan 20 '23 21:01 e0d

@e0d I removed Note: don't merge in description, did I understand you correctly?. Yes, I think nothing prevents merge it now)

UvgenGen avatar Jan 20 '23 22:01 UvgenGen

@dianakhuang is this good to merge now? @arbrandes FYI as MFE guru and Olive release lead.

e0d avatar Jan 20 '23 22:01 e0d

I will try to get it on FED-BOM's agenda to review and help get this merged. Very excited for this to land!

dianakhuang avatar Jan 24 '23 14:01 dianakhuang

@UvgenGen need rebasing again due to frequent changes in platform :) or you can give me write access to your forked repo so i can update changes.

abdullahwaheed avatar Jan 26 '23 09:01 abdullahwaheed

@abdullahwaheed PR rebased)

UvgenGen avatar Jan 26 '23 19:01 UvgenGen

Hi @UvgenGen @arbrandes @dianakhuang - is this good to merge once the branch conflicts are resolved?

mphilbrick211 avatar Feb 24 '23 02:02 mphilbrick211

@mphilbrick211 PR rebased, conflicts resolved)

UvgenGen avatar Mar 03 '23 12:03 UvgenGen

@arbrandes @dianakhuang Would one of you be able to merge this?

mphilbrick211 avatar Mar 07 '23 01:03 mphilbrick211

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Mar 07 '23 12:03 openedx-webhooks

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot avatar Mar 07 '23 13:03 edx-pipeline-bot

EdX Release Notice: This PR has been deployed to the production environment.

edx-pipeline-bot avatar Mar 07 '23 13:03 edx-pipeline-bot