Tyler Helmuth comments

Results 797 comments of


                                            Tyler Helmuth

[collector] Consider a preset for logs+metrics collection based on annotation discovery

I'm curious to understand more about the logs scenario

[collector] Consider a preset for logs+metrics collection based on annotation discovery

Ya we can error in `NOTES.txt`.

[collector] Consider a preset for logs+metrics collection based on annotation discovery

@ChrsMark can you post what you think the preset configuration would be? I suspect it would need a user to supply a string annotation and we've typically been very against...

[collector] Consider a preset for logs+metrics collection based on annotation discovery

That looks good. What annotation does a pod need to get scraped by the collector?

[collector] Consider a preset for logs+metrics collection based on annotation discovery

Ok lets move forward with this preset

feat(demo): add ipv6 environment vars

I agree we dont need a new example for this situation.

feat(opentelemetry-collector): add automountServiceAccountToken param for sa

@ppatel1604 are you by any chance generating the examples with an old version of helm? They are still out of sync. You can also simplify the generation with `make generate-examples...

feat(opentelemetry-collector): add automountServiceAccountToken param for sa

When I checkout your branch and run `make generate-examples CHARTS=opentelemetry-collector` locally I do get changes.

[otel-kube-stack] Failure to use numeric values in `Instrumentation` env vars: `Invalid value: "integer`

It looks like our json schema is enforcing `value` to be a string, which is also what your error message is asking for. Is the supplied values.yaml how you produced...

[operator] manager.targetAllocatorImage.repository not enough to configure a private registry

I'm not sure I understand. If you set `.Values.manager.targetAllocatorImage.repository` in your values.yaml you dont have to set `.Values.manager.targetAllocatorImage.tag`.