Tyler Helmuth

Results 797 comments of Tyler Helmuth

I agree we should probably keep it until k8s completely drops support.

@dmitryax I agree that component metrics should be emitted with `Normal` and that `Normal` should be the default level. I agree with `Basic` being only those generic receiver/processor/exporter metrics. For...

> But I agree it would be nice to have this capability right in service::telemetry::metrics. Out of scope for this issue for sure, but I agree.

> I wonder if this approach is becoming too specific to be useful. HTTP and gRPC status codes (and conversion between them) should be protocol agnostic. Is there any way...

@jmacd I may not be understanding the issue well enough, but the intention is that the exporter in question translate its grpc status to the OTLP equivalent grpc status and...

Is it correct to say from a component developer perspective it doesn't matter where it lives?

> probably make it part of Conf.Unmarshal (configurable) to also do validation. Today I believe that `otelcol` is our collector's use of `ConfigValidator`. What problem would we be solving by...

I'll submit a PR to move validation stuff to `xcomponent`.

@bogdandrutu @atoulme @dmitryax would adding support for https://github.com/go-playground/validator be a breaking change? Config validation is an important part of collector 1.0 and the Validator interface is a sufficient solution. I...