Tyler Helmuth

Results 797 comments of Tyler Helmuth

Ok lets try with just breaking it. Are there any security concerns here? It seems likely you could do something like `merge_maps(attributes, ctx, "upsert")`, and expose keys.

Requiring an index should be enforceable by the ottl context path function. I agree we should only support string keys.

In that case, I think we should be extremely strict about NOT adding any `KeyFunc` converters to `pkg/ottlfuncs`.

@djaglowski and I talked a bit about this at kubecon. We think we can get away with including the `context.Context` in the TransformContext and then adding specific paths to each...

Ultimately I'd still prefer we use an OTTL context that supplies paths to other OTTL contexts as the way to implement this feature. Since the feature is data access, and...

@thejoeejoee thanks for the details. Feel free to submit PRs that add more tpl support.

We can transition to the default exporters we have using the default exporterhelper batch setup. The transition could be: 1. Add a field that, when true, toggles the default config...

@itsvshreyas can you test this implementation in a fork so we can see the release action run? You may need to update some CI to be based on your fork...

@itsvshreyas thanks for testing, those release notes look good. You can remove the testing changes.