Torkel Loman
Torkel Loman
I will see if I can come up with something
I think the reason that there is lots of diff is that there has been quite widespread rewriting and reordering to most parts of the text, i.e. the changes probably...
Ok, this one is read. Two additional comments: - The `(@ref ref)` mark where I want to put links to places in the docs. However, I cannot actually put these...
I agree with that. I am not really fond of the current merging of the model properties and model construction bit, but it really is not something we should prioritise...
yes, all fixed
Not too surprised. I will have a look locally (the test log is too large to actually see what is going on)
Ok, tests pass now (except for one downstream test)
> I should have mentioned: I'll move the tests when I PR to SciMLBase to fix the bugs Thanks!
Yeah, I am a bit uncertain what actually goes where now when the MTK pipeline have been split up in so many different places. To me it is basically tests...
For the `save_idx` I think it is just that it has been broken since the very beginning. It is something that should be supported, so don't think it is bad...