Tom Tan
Tom Tan
Close the PR for now. Feel free to reopen it if it is still valid.
The CI should have been fixed by https://github.com/open-telemetry/opentelemetry-cpp/pull/2696.
Updated both title and the proposal and fixed it. I meant table name which is internally set as ETW event name. As the internal ETW event name cause confuse with...
> Both options will require the users to change instrumentation if they want to change the destination table name, which seems to go against the separation of API and SDK...
> > OpenTelemetry API has library name in [GetLogger](https://github.com/open-telemetry/opentelemetry-cpp/blob/78d488ca44d6a9aed79e63da739b081e20c94207/api/include/opentelemetry/logs/logger_provider.h#L41) > > BTW, why is this called "library name" instead of "name"? (instrumentation scope) Sounds a bit confusing to me. Is...
Should this PR be included in the coming minor build (like 1.7.0) instead of patch build?
Reviewed the `GetTracer` API. The same issue is not there. @lalitb thanks for the reminder. https://github.com/open-telemetry/opentelemetry-cpp/blob/4f37503105d1572423e161ca171ac8d046d66341/api/include/opentelemetry/trace/tracer_provider.h#L121
FYI, the CI for fluentd exporter was added, but it may not test the logic path in this PR. https://github.com/open-telemetry/opentelemetry-cpp-contrib/blob/main/.github/workflows/fluentd.yml
@nefarius the vcpkg port of opentelemetry package is not officially supported by this repo, so you could report the same issue to the vcpkg to get more visibility. Meanwhile, could...
@lalitb any comment on this?