opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[REMOVAL] Remove build option `WITH_DEPRECATED_SDK_FACTORY`

Open marcalff opened this issue 1 year ago • 2 comments

Fixes #2716

Changes

Please provide a brief description of the changes here.

  • Removed CMake option WITH_DEPRECATED_SDK_FACTORY
  • Removed old references to CMake option WITH_OTLP
  • Removed old references to CMake option WITH_LOGS_PREVIEW

For significant contributions please make sure you have completed the following items:

  • [X] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

marcalff avatar Jun 25 '24 22:06 marcalff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.66%. Comparing base (497eaf4) to head (87b00e9). Report is 105 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2717      +/-   ##
==========================================
+ Coverage   87.12%   87.66%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5858     -251     
==========================================
- Hits         5322     5135     -187     
+ Misses        787      723      -64     
Files Coverage Δ
sdk/src/logs/event_logger_provider_factory.cc 100.00% <ø> (ø)
sdk/src/trace/tracer_provider_factory.cc 44.83% <ø> (+0.39%) :arrow_up:

... and 119 files with indirect coverage changes

codecov[bot] avatar Jun 25 '24 22:06 codecov[bot]

Please review.

I suggest to wait at one or two weeks for possible comments on this (the removal issue is pinned), before merging to main.

marcalff avatar Jun 25 '24 22:06 marcalff

Should this PR be included in the coming minor build (like 1.7.0) instead of patch build?

ThomsonTan avatar Jul 15 '24 21:07 ThomsonTan

Should this PR be included in the coming minor build (like 1.7.0) instead of patch build?

Current release is 1.16.0, so next patch build will be 1.16.1

This removal should only be part of release 1.17.0, and not part of the 1.16.1 patch, I agree.

marcalff avatar Jul 16 '24 00:07 marcalff