Tom Tan comments

Results 74 comments of


                                            Tom Tan

Use `nostd::enable_if_t` instead of `std::enable_if_t`

> This PR looks ok. > > The build failure on MacOS seems unrelated, and to fix separately. Curious on what triggered the MacOS build warning.

Are there docs/examples for the logging functionality?

@Falmarri , our API docs are still under progress. Our API is intended for general purpose logging, but currently we only support OpenTelemetry backend (SDK&exporter). Wondering which logging scenario you...

OStreamLogRecordExporter doesn't copy message data and attributes

Another thought, should we limit the usage of `OStreamLogRecordExporter` in async pipeline as the `BatchLogRecordProcessor`? So we don't need to make copies of the attributes for most common cases.

OStreamLogRecordExporter doesn't copy message data and attributes

Making copy could make sense because the OStream exporter is mostly for debugging purpose.

Update ExemplarFilter and ExemplarReservoir for spec

Talked with Lalit. He is fine to merge this PR and address potential feedback in future PRs. I am going to merge it for now.

Avoid missing conditional variable update and simplify atomic bool

Is it possible to add a test case to reproduce the issue and verify the fix?

[Request for Maintenance] CPP tooling in open-telemetry/build-tools

I support this idea of moving `cpp-build-tools` to a new repo.

[SDK] Fix forceflush may wait for ever

BTW, can you explain in brief that why the sequence notification can break the potential forever wait? Thanks.

Bazel build of example failed

@shiponcs what OpenTelemetry SDK version is built here?

Remove unnecessary usages of nostd::type_traits in API.

> Some old toolchains do not support C++14 libraries completely. Could we just keep the nostd version here? But C++ 14 is required for OpenTelemetry. Or which version of toolchain...