Tom Tan

Results 74 comments of Tom Tan

Apologize for blocking the PR. I think this is the exactly the issue I raised before. The user application builds fine with either new SDK headers/old SDK libs, or old...

> > The user application builds fine with either new SDK headers/old SDK libs, or old SDK headers/new SDK libs, either one will trigger a runtime break which is very...

> Will the `message-template` formatted log body and its structure being preserved when OTel-Cpp exports the log data e.g. through OTLP to a collector (and eventually to a backend logging...

> Hey, how can I help on this issue? Could you please add comments on which issue you are interested? We can assign it to you to look into.

@dbarker the contrib repo exporters could be included via below cmake line when configured. https://github.com/open-telemetry/opentelemetry-cpp/blob/9451f0e3be7c1030ae0f78b03b7211aad99a7dcf/cmake/opentelemetry-build-external-component.cmake#L27

> I see this as well. This is related to (I think? Maybe?) [`main`/sdk/include/opentelemetry/sdk/common/attribute_utils.h#L165](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/include/opentelemetry/sdk/common/attribute_utils.h#L165) > > and a consequence of inheriting from std::unordered_map which isn't a great idea for the...

Thanks for raising the issue, @santiagorr. We have googletest as submodule under https://github.com/open-telemetry/opentelemetry-cpp/tree/main/third_party. Would that be very different than the `ExternalProject` / `FindGTest` approach?

> Yes, our team ( Microsoft Mesh ) uses the decoder, as well as the C# test server in our test automation. We need it back. @maxgolov feel free to...

[@mkoscumb](https://github.com/mkoscumb), could you please resolve the conflicts in this PR?