Hannah von Reth comments

Results 161 comments of


Hannah von Reth

[Wizard] Token endpoint with self-signed certificate doesn't raise TLS error and accept page

Did you try it with mitmproxy? Mitmproxy usually adds another layer of self signed certs.

Nautilus integration on Rocky Linux is missing in AppImage

The filebrowser extension is not part of the appImage and needs to be installed from either our repos or from your distribution.

[OIDC] fallback to static client id when OIDC DCR fails

Looking at the code, this should already be the case...

[OIDC] fallback to static client id when OIDC DCR fails

I implemented two unit tests for dynamic registration and the fallback appears to be working.

[OIDC] fallback to static client id when OIDC DCR fails

In that case we the authentication fails as we can't compare the server provided user with the requested user. This check is required to prevent mixing up the sync of...

[OIDC] fallback to static client id when OIDC DCR fails

Can you retest with a current client? Was https://github.com/owncloud/client/commit/e939d8b20cfed3b826bfdcd08383634c9f75395d already part of your build?

[OIDC] fallback to static client id when OIDC DCR fails

Please test

[QA] owncloud context menu and overlay icons should remain when sync is paused

Relevant code: https://github.com/owncloud/client/blob/f6a7527125dfc6244227ece0232f8f883cea0265/src/gui/folderman.cpp#L475-L475 https://github.com/owncloud/client/blob/f6a7527125dfc6244227ece0232f8f883cea0265/src/gui/folder.cpp#L347-L347 Not sure what the impact of a change would be.

Link creation inconsistent between quick action and share window

Please test with 3.0

[QA] admin or guest user cannot connect a desktop or mobile client

So what are the expectations? That the client performs basic auth until the accounts are properly setup? I fail to see the problem?