client
client copied to clipboard
[QA] owncloud context menu and overlay icons should remain when sync is paused
Pre-submission Checks
- [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
- [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.
Describe the QA issue
Seen while testing client 2.11.1 on Linux Mint
- connect client with e.g. demo.owncloud.org
- Install nemo *-nemo boreser integration package.
- Restart nemo.
- overlay icons appear and right click has the owncloud sub menu.
- pause sync
- overlay icons disappear, no owncloud menu.
- resum sync
- overlay icons re-appear. owncloud menu is back.
Expected behaviour:
- The right click context menu is always there, as e.g. sharing settings are independant of any syncing on the local client.
- The overlay icons could also remain, and show e.g. a yellow (II) pause icon, just as the tray icon does.
Workaround: resume sync for a short moment, while accessing the context menu.
- The user has no indication in the file browsers, why no menus and icons are not showing.
- Energy and bandwidth is wasted for an unneeded 'resume sync' when I just want to edit a share.
Steps to reproduce the issue
.
Screenshots
.
Expected behavior
.
Actual behavior
.
Relevant code: https://github.com/owncloud/client/blob/f6a7527125dfc6244227ece0232f8f883cea0265/src/gui/folderman.cpp#L475-L475 https://github.com/owncloud/client/blob/f6a7527125dfc6244227ece0232f8f883cea0265/src/gui/folder.cpp#L347-L347
Not sure what the impact of a change would be.