Matt Corallo

Disallow dual-sync-async persistence without restarting

12

In general, we don't expect users to persist `ChannelMonitor[Update]`s both synchronously and asynchronously for a single `ChannelManager` instance. If a user has implemented asynchronous persistence, they should generally always use...

`rustfmt` non-test `ln` module's not-currently-being-edited files

1

This `rustfmt`s most of the remaining files in `ln` that aren't `channel{,manager}.rs`, `outbound_payment.rs` and `*_tests.rs`. It avoids `onion_utils` since that may get more edits for trampoline, `peer_handler.rs` (since that's #3725),...

Run rustfmt on `payment_tests` and `functional_tests` and split up the latter

6

`functional_tests`' time has come, and there's some easy batches of tests to move into separate files. Even at the end its still 10k LoC, but that's better than the 14K...

async signing completion

4

A few nits from https://github.com/lightningdevkit/rust-lightning/pull/3109#pullrequestreview-2503323296 and then all we need is to handle async per-commitment-point in reconnection.

Drop deprecated methods in `invoice_utils`

1

These methods are super trivial to replace with the `ChannelManager` equivalent, so keeping them around for a while doesn't give us anything.

Test generated-route valididty in fuzzing

2

While our router fuzzer is pretty good at hitting internal assertions in our pathfinder, it doesn't actually do anything to check that the returned route is valid (or meets the...

Store `Feature` flags in line rather than on the heap by default (without increasing their size)

5

In a running LDK instance we generally have a ton of `Feature`s objects flying around, including ones per channel/peer in the `NetworkGraph`, ones per channel/peer in `Channel`/`ChannelManager`, and ones inside...

Make `BumpTransactionEventHandler` async-optional

6

Turns out this it the only async -> sync -> (blocked) async inversion we have in `ldk-sample`, so making the traits async-optional (via some proc-macro?) would be really nice.

Log which hop in a path was the most limiting in capacity

2

Its generally rather difficult to debug the pathfinding logic from a log, and sadly because we cannot feasibly log each step in a pathfinding search there's relatively few options we...

Move BOLT 12 into its own crate

4

As long as there are no dependencies we want to take that want to depend on our invoice types, there's no reason to have them in a separate crate, but...