rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Test generated-route valididty in fuzzing

Open TheBlueMatt opened this issue 9 months ago • 2 comments

While our router fuzzer is pretty good at hitting internal
assertions in our pathfinder, it doesn't actually do anything to
check that the returned route is valid (or meets the requirements
given to the pathfinder).

Here we add some initial checks covering the feerates of the hops
taken in the returned route.

Currently fails because of https://github.com/lightning/bolts/issues/1249

TheBlueMatt avatar Apr 10 '25 15:04 TheBlueMatt

👋 Hi! This PR is now in draft status. I'll wait to assign reviewers until you mark it as ready for review. Just convert it out of draft status when you're ready for review!

ldk-reviews-bot avatar Apr 10 '25 15:04 ldk-reviews-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.13%. Comparing base (233aa39) to head (908c5bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3728   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files         157      157           
  Lines      123959   123968    +9     
  Branches   123959   123968    +9     
=======================================
+ Hits       110485   110497   +12     
- Misses      10791    10796    +5     
+ Partials     2683     2675    -8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 28 '25 18:04 codecov[bot]