Matt Corallo

Results 964 comments of Matt Corallo

also claimable events are/should be generated on restart, i believe?

Really need to find time for this one, but it'll have to be 117.

Hmmm, I'm definitely a fan of moving code out of get_route, but passing in 28 arguments doesn't really improve readability :/. For panics specifically, luckily the panic messages share the...

The other issue we're gonna hit is the routefinding rewrites in #2803 are going to conflict heavily here :/

Okay...the bulk of #2803 landed. Any desire to pick this back up?

Nice, yea, in principle this looks great to me, assuming benchmarks don't turn up anything weird (might well be faster cause improved code density).