Matt Corallo comments

Results 964 comments of


                                            Matt Corallo

Use unique per-node "node_counter"s rather than a node hashmap in routing

It is all pretty trivial, but at least eg the feature optimization and the first hop cache thing could probably use another pair of eyes.

Use unique per-node "node_counter"s rather than a node hashmap in routing

Gonna go ahead and land to get this done, but will tackle nits in a quick followup.

Make on-startup monitor replay more robust

> Have read return a UninitializedChannelManager wrapping ChannelManager and only exposing methods that can safely be called. Presumably just chain::Confirm and chain::Listen. Mmm, indeed we could. > Add an initialize...

[Clarity] Minor Docs

Slipping to 114, not sure why this has a 113 tag if it wasnt assigned to anyone.

[Clarity] Minor Docs

Yea, I'm honestly not sure what the first one refers to. The second is kinda implied by docs today, but we definitely need to include it when we rewrite docs...

[Clarity] Minor Docs

@G8XSU mind opening a PR for this?

[Clarity] Minor Docs

@G8XSU any update?

[Clarity] Minor Docs

Don't think there's anything left for this after #2992.

Figure out path-length-limiting when routing with metadata/blinded paths

This is important to fix, but it doesn't *need* to be fixed for MVP of BOLT12, slipping to 117.

Figure out path-length-limiting when routing with metadata/blinded paths

Still important, but still not *that* important. We don't really ever generate routes that are that long for other reasons, and if someone gives us a stupidly long route and...