Tanay Parikh

Results 157 comments of Tanay Parikh

Companion PR: https://github.com/dotnet/maui/pull/9393

@dougbu @wtgodbe do you happen to know if we're okay to merge, or must this go through tactics?

> Seems fine as a tell-mode PR to me. Sounds good, thanks! cc/ @marcpopMSFT in case you have any concerns :) (Not seeing a `tell-mode` label so not annotating anything).

> Tell mode is generally used for infrastructure changes and test changes. Isn't this a change to the customer-facing razor targets? Yes these targets will have direct customer impact. This...

> @javiercn @TanayParikh do you use some tool to generate the baselines for the blazor tests? Yes. I believe it's just a matter of updating: https://github.com/dotnet/sdk/blob/dc4f499509dfa708926ff6639bc800f78a00202f/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs#L29-L33 However, is this change...

I can definitely do it, but just want to confirm if this is an expected change. I believe @pavelsavara has been making some changes in this area so he may...

> This hasn't changed in the last year. Essentially just need to add a `#define GENERATE_SWA_BASELINES` to the top of the file to trigger baseline generation instead of actually running...

Looks like we're seeing a new error now: Microsoft.DotNet.Watcher.Tools.GlobbingAppTests.DeleteSourceFolder (and other tests) ``` Expected command to pass but it did not. File Name: /root/helix/work/correlation/d/dotnet Arguments: msbuild /t:Build /root/helix/work/workitem/e/testExecutionDirectory/DeleteSourceF---587A3DCE/WatchGlobbingApp.csproj /restore Exit...

There are some binlogs in the artifacts, not sure if those would help? https://dev.azure.com/dnceng/public/_build/results?buildId=1946548&view=artifacts&pathAsName=false&type=publishedArtifacts