sdk
sdk copied to clipboard
dotnet
Backport Razor Static Web Assets Manifest Path Changes
Backports:
- https://github.com/dotnet/sdk/pull/26765
- https://github.com/dotnet/sdk/pull/27102
Will also need: https://github.com/dotnet/maui/pull/9348 -> https://github.com/dotnet/maui/pull/9393
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
![dotnet-issue-labeler[bot] avatar](https://avatars.githubusercontent.com/in/90031?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dougbu @wtgodbe do you happen to know if we're okay to merge, or must this go through tactics?
Seems fine as a tell-mode PR to me.
Sounds good, thanks! cc/ @marcpopMSFT in case you have any concerns :)
(Not seeing a tell-mode label so not annotating anything).
Tell mode is generally used for infrastructure changes and test changes. Isn't this a change to the customer-facing razor targets?
Tell mode is generally used for infrastructure changes and test changes. Isn't this a change to the customer-facing razor targets?
Yes these targets will have direct customer impact. This is required to help resolve https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099 which is causing hot reload failures in .NET 6. We'll be merging this in conjunction with https://github.com/dotnet/maui/pull/9393.
@marcpopMSFT what would you suggest the appropriate process be in that case? Ask mode (ask you?) or would it be through tactics + servicing template?
Since there is direct customer impact, I would mark servicing-consider, update the description with the template (look for other servicing-approved bugs for the template), and send mail to tactics.
@TanayParikh @mkArtakMSFT @javiercn pinged offline as well but if this is needed for servicing, it should be merged today.