Andrea Pappacoda

Results 301 comments of Andrea Pappacoda

> @Tachi107 I copy/pasted the Creative Commons Attribution-ShareAlike 3.0 Unported license into notepad. Seems okay. But maybe there is better source with files in .txt format? Yes, there is. You...

> I swapped out the license with the .txt direct from Creative Commons. Why? easier to read on GitHub, or in less. Yeah I guess that is fine too. If...

According to [ARMmbed/mbedtls/docs/3.0-migration-guide.md](https://github.com/ARMmbed/mbedtls/blob/development/docs/3.0-migration-guide.md#rename-mbedtls__ret-cryptography-functions-whose-deprecated-variants-have-been-removed) the function `mbedtls_sha256_ret` has been removed, and it is used by yuzu in various places. https://github.com/yuzu-emu/yuzu/blob/1b09d6628b7f268c256c12e4d3e373724671d2f1/src/core/file_sys/registered_cache.cpp#L67 https://github.com/yuzu-emu/yuzu/blob/1b09d6628b7f268c256c12e4d3e373724671d2f1/src/core/file_sys/registered_cache.cpp#L149 https://github.com/yuzu-emu/yuzu/blob/065867e2c24e9856c360fc2d6b9a86c92aedc43e/src/core/file_sys/xts_archive.cpp#L69 https://github.com/yuzu-emu/yuzu/blob/c5ca8675c84ca73375cf3fe2ade257c8aa5c1239/src/core/crypto/partition_data_manager.cpp#L183 https://github.com/yuzu-emu/yuzu/blob/c5ca8675c84ca73375cf3fe2ade257c8aa5c1239/src/core/crypto/partition_data_manager.cpp#L211 https://github.com/yuzu-emu/yuzu/blob/00ce8eff65190d2049e25665fe0b3f99f716a99f/src/core/hle/service/bcat/backend/boxcat.cpp#L280 https://github.com/yuzu-emu/yuzu/blob/4ea171fa5e50723d50b57b26aaaca2fac30eea57/src/core/hle/service/ldr/ldr.cpp#L472 https://github.com/yuzu-emu/yuzu/blob/1b09d6628b7f268c256c12e4d3e373724671d2f1/src/core/crypto/key_manager.cpp#L488

(slightly) Faster compile times, smaller binary size, possibilty to update MbedTLS without having to recompile yuzu, and would make things simpler for downstream. This is also for consistency, since a...

> The major blocker here would be API compatibility (obviously, given that 3.0 has just released), and we've had issues in the past where system bundled libraries are severely out...

> I am also accounting for the scenario where some distributions may include API breaking versions (newer or older, depending on if yuzu uses 2.x or 3.x) Easy solution! `mbedtls/version.h`...

> There's also one other detail I've just recalled. When I've migrsted the project from an older version mbedtls 2.x to 2.16, there was a small API breaking change due...

Now `find_package()` will only accept MbedTLS version 2.16.x :) Edit: Ops, fixing now... Edit 2: Fixed

Hey @Morph1984, CMAC support in libmbedcrypto has been recently added in Debian (see [here](https://tracker.debian.org/media/packages/m/mbedtls/changelog-2.16.11-0.1)), so this patch will be now useful in practice for Debian (and derivatives like Ubuntu) users....