yuzu icon indicating copy to clipboard operation
yuzu copied to clipboard

Moving Icons away from CC BY-ND 3.0 licensed Icons to help with FOSS Packaging

Open Docteh opened this issue 2 years ago • 10 comments

I've seen some comments stating that sharing pre-compiled binaries is problematic for linux distributions due to the CC BY-ND 3.0 license

In this commit I am tackling the 16x16 icons

The reported status of the "yuzu Web Service" section of Configuration uses two icons, checked and failed

checked is replaced by material-design-icons check_circle failed is replaced by material-design-icons error

Colors have been set by taking the white pngs of 18x18, cropping to 16x16, and then adjusting Curves using Paint.NET

Other tools are available.

There is also a locked icon that does not appear to be used in the current code. citra uses it for multiplayer

lock is replaced by material-designs-icons lock

Some of the colorful theme icons are clearly from https://github.com/icons8/flat-color-icons/ which is available MIT licensed

Sources for MIT license: https://github.com/icons8/flat-color-icons/issues/5 https://github.com/icons8/flat-color-icons/blob/master/package.json

This covers plus_folder, bad_folder, chip, folder

Leaving plus, sd_card and star to need further research/replacement

The first two are user visible, the lock icons aren't used right now. image

The lock icons are shoddily replaced to avoid having to test and verify that removal doesn't break anything.

Fixes #8077

Docteh avatar Mar 28 '22 21:03 Docteh

I find the checked.png icon hard to look at with a white background. Would it be possible to darken its green a bit?

Edit: also, the "wont totally fix #8077" in the PR description will actually close the linked issue, you should put something between fix and the issue number, or replace fix with something like "related to"

Edit 2: you could also try downloading the SVGs and resize them instead of resizing rasterized PNGs; it might lead to slightly better quality

Tachi107 avatar Mar 29 '22 12:03 Tachi107

The Noun Project offers icons licensed under the free CC-BY-3.0 license. They feature a lot of icons, like SD card icons

Tachi107 avatar Mar 29 '22 16:03 Tachi107

I'm not actually resizing the images, its a crop image

Retint of the checked.png, I grabbed the color from the current checked.png image

I'm going to convert this to a draft, just to avoid builds being generated when I push

Docteh avatar Mar 29 '22 18:03 Docteh

Current icons image

https://remixicon.com/ Apache 2.0 image

Hero Icons, MIT https://github.com/tailwindlabs/heroicons

This one looks closer to what icons8 has. It doesn't have an SD Card, but that can be gotten to. image

bad_folder

Personally, I lean towards liking heroicons

@Tachi107 they have a LOT of icons to look through.

  • [ ] are heroicons good enough?
  • [ ] sd cards

Docteh avatar Mar 30 '22 01:03 Docteh

I've got all the ND icons replaced, so I squashed it down, and have double checked the changes to dist/license.md

Previous Colorful image

sd_card, star, plus changed in this PR image

New White icons image

Docteh avatar Mar 30 '22 14:03 Docteh

Two changes, that I'll commit later. I don't want to spam builds. (These are the 48x48 pngs that will be commited later)

Star, Original color: EFCE4A different color: FFCA28 Set size to 42 star

SD Card is also a bit big, initially rasterized 48x48, better off at 44x44 sd_card

Current PR/Preview with these changes imageimage

Docteh avatar Apr 03 '22 19:04 Docteh

For the monochromatic icons I'm not sure if they should be filled in or not, but after staring at a lot of icons I believe they should be the same

Current image

This PR image

Docteh avatar Apr 11 '22 23:04 Docteh

#8541 adds 11 more icons, in that, 3 variants of 3, and 2 variants of 1 add up to 11. I complained over there about the issue, might need a reminder.

I got feedback from @german77 that the SD card looks like a foot, changed it out. Still a few pins short, but at 48x48 accuracy might he bard to see. image

Redrew plus signs, the green felt too small, the others felt too big. I had a hard time seeing the exclamation mark in failed, so it's also replaced plus plus plus failed

Docteh avatar Jul 19 '22 14:07 Docteh

@IvarWithoutBones Looks like #8541 got merged https://github.com/yuzu-emu/yuzu/commit/705f7db84dd85555a6aef1e136cf251725cef293 so I'll need to dedicate some time for those.

/usr/share/icons/breeze/actions/16/ image

/usr/share/icons/breeze/status/16 image image

Docteh avatar Jul 26 '22 02:07 Docteh

Thanks for the hard work and keeping us updated, its much appreciated ☺️

IvarWithoutBones avatar Jul 26 '22 08:07 IvarWithoutBones

Big August Update!

... I reworked the changes to dist/license.md (now retired) to the new .reuse/dep5 file

#8541 also adds some other icons, so

Remaining NO DERIVATIVES

Files: dist/qt_themes/*/icons/16x16/connected.png
       dist/qt_themes/*/icons/16x16/connected_notification.png
       dist/qt_themes/*/icons/16x16/disconnected.png
       dist/qt_themes/*/icons/48x48/no_avatar.png
Copyright: https://icons8.com
License: CC-BY-ND-3.0

no_avatar candidates, https://ionic.io/ionicons https://github.com/ionic-team/ionicons (person) no_avatar no_avatar

Docteh avatar Aug 13 '22 13:08 Docteh

@Tachi107 I copy/pasted the Creative Commons Attribution-ShareAlike 3.0 Unported license into notepad. Seems okay. But maybe there is better source with files in .txt format?

Docteh avatar Aug 14 '22 04:08 Docteh

@Docteh I tried appending .txt to the license URL and that seems to return a plain text version of the CC-BY-SA 3.0: https://creativecommons.org/licenses/by-sa/3.0/legalcode.txt

sbruder avatar Aug 14 '22 07:08 sbruder

@Tachi107 I copy/pasted the Creative Commons Attribution-ShareAlike 3.0 Unported license into notepad. Seems okay. But maybe there is better source with files in .txt format?

Yes, there is. You can use reuse download --all to download all the licenses used by the project into the 'LICENSES/` folder.

You can install the reuse tool on Debian with apt install reuse, or via pip with pip3 install reuse

Tachi107 avatar Aug 14 '22 12:08 Tachi107

I swapped out the license with the .txt direct from Creative Commons. Why? easier to read on GitHub, or in less.

Goes well with CC0-1.0.txt, also nicely formatted.

Docteh avatar Aug 14 '22 14:08 Docteh

I swapped out the license with the .txt direct from Creative Commons. Why? easier to read on GitHub, or in less.

Yeah I guess that is fine too. If the reuse CI job passes it means that everything is OK

Tachi107 avatar Aug 14 '22 14:08 Tachi107

Thanks for merging!

Tachi107 avatar Aug 15 '22 16:08 Tachi107