yuzu
yuzu copied to clipboard
Moving Icons away from CC BY-ND 3.0 licensed Icons to help with FOSS Packaging
I've seen some comments stating that sharing pre-compiled binaries is problematic for linux distributions due to the CC BY-ND 3.0 license
In this commit I am tackling the 16x16 icons
The reported status of the "yuzu Web Service" section of Configuration uses two icons, checked and failed
checked is replaced by material-design-icons check_circle failed is replaced by material-design-icons error
Colors have been set by taking the white pngs of 18x18, cropping to 16x16, and then adjusting Curves using Paint.NET
Other tools are available.
There is also a locked icon that does not appear to be used in the current code. citra uses it for multiplayer
lock is replaced by material-designs-icons lock
Some of the colorful theme icons are clearly from https://github.com/icons8/flat-color-icons/ which is available MIT licensed
Sources for MIT license: https://github.com/icons8/flat-color-icons/issues/5 https://github.com/icons8/flat-color-icons/blob/master/package.json
This covers plus_folder, bad_folder, chip, folder
Leaving plus, sd_card and star to need further research/replacement
The first two are user visible, the lock icons aren't used right now.
The lock icons are shoddily replaced to avoid having to test and verify that removal doesn't break anything.
Fixes #8077
I find the checked.png icon hard to look at with a white background. Would it be possible to darken its green a bit?
Edit: also, the "wont totally fix #8077" in the PR description will actually close the linked issue, you should put something between fix and the issue number, or replace fix with something like "related to"
Edit 2: you could also try downloading the SVGs and resize them instead of resizing rasterized PNGs; it might lead to slightly better quality
The Noun Project offers icons licensed under the free CC-BY-3.0 license. They feature a lot of icons, like SD card icons
I'm not actually resizing the images, its a crop
Retint of the checked.png, I grabbed the color from the current checked.png
I'm going to convert this to a draft, just to avoid builds being generated when I push
Current icons
https://remixicon.com/ Apache 2.0
Hero Icons, MIT https://github.com/tailwindlabs/heroicons
This one looks closer to what icons8 has. It doesn't have an SD Card, but that can be gotten to.
Personally, I lean towards liking heroicons
@Tachi107 they have a LOT of icons to look through.
- [ ] are heroicons good enough?
- [ ] sd cards
I've got all the ND icons replaced, so I squashed it down, and have double checked the changes to dist/license.md
Previous Colorful
sd_card, star, plus changed in this PR
New White icons
Two changes, that I'll commit later. I don't want to spam builds. (These are the 48x48 pngs that will be commited later)
Star, Original color: EFCE4A different color: FFCA28 Set size to 42
SD Card is also a bit big, initially rasterized 48x48, better off at 44x44
Current PR/Preview with these changes
For the monochromatic icons I'm not sure if they should be filled in or not, but after staring at a lot of icons I believe they should be the same
Current
This PR
#8541 adds 11 more icons, in that, 3 variants of 3, and 2 variants of 1 add up to 11. I complained over there about the issue, might need a reminder.
I got feedback from @german77 that the SD card looks like a foot, changed it out. Still a few pins short, but at 48x48 accuracy might he bard to see.
Redrew plus signs, the green felt too small, the others felt too big. I had a hard time seeing the exclamation mark in failed
, so it's also replaced
@IvarWithoutBones Looks like #8541 got merged https://github.com/yuzu-emu/yuzu/commit/705f7db84dd85555a6aef1e136cf251725cef293 so I'll need to dedicate some time for those.
/usr/share/icons/breeze/actions/16/
/usr/share/icons/breeze/status/16
Thanks for the hard work and keeping us updated, its much appreciated ☺️
Big August Update!
... I reworked the changes to dist/license.md
(now retired) to the new .reuse/dep5
file
#8541 also adds some other icons, so
Remaining NO DERIVATIVES
Files: dist/qt_themes/*/icons/16x16/connected.png
dist/qt_themes/*/icons/16x16/connected_notification.png
dist/qt_themes/*/icons/16x16/disconnected.png
dist/qt_themes/*/icons/48x48/no_avatar.png
Copyright: https://icons8.com
License: CC-BY-ND-3.0
no_avatar candidates, https://ionic.io/ionicons https://github.com/ionic-team/ionicons (person)
@Tachi107 I copy/pasted the Creative Commons Attribution-ShareAlike 3.0 Unported license into notepad. Seems okay. But maybe there is better source with files in .txt format?
@Docteh I tried appending .txt
to the license URL and that seems to return a plain text version of the CC-BY-SA 3.0: https://creativecommons.org/licenses/by-sa/3.0/legalcode.txt
@Tachi107 I copy/pasted the Creative Commons Attribution-ShareAlike 3.0 Unported license into notepad. Seems okay. But maybe there is better source with files in .txt format?
Yes, there is. You can use reuse download --all
to download all the licenses used by the project into the 'LICENSES/` folder.
You can install the reuse
tool on Debian with apt install reuse
, or via pip with pip3 install reuse
I swapped out the license with the .txt direct from Creative Commons. Why? easier to read on GitHub, or in less.
Goes well with CC0-1.0.txt, also nicely formatted.
I swapped out the license with the .txt direct from Creative Commons. Why? easier to read on GitHub, or in less.
Yeah I guess that is fine too. If the reuse CI job passes it means that everything is OK
Thanks for merging!