Andrea Pappacoda
Andrea Pappacoda
> string_view doesn't actually promise that a string is null-terminated, but we do null-terminate strings in ondemand This doesn't seem the case, as `object["key"].get_string().value().data()` doesn't return a NULL-terminated string
Yes, NULL-terminating the returned string without allocating new memory could be problematic for simdjson, as as far as I know you just iterate over the json content without modifying it....
Until Dynarmic starts tagging releases more frequently (i.e. semantic versioning) it will be hard to reliably use a shared version of it
Hey @abouvier, could you please rebase this again? The patch can't be cleanly applied since #8134 was merged
That's true, but recently Dynarmic started tagging releases more often, thus making it easier to stick to a specific version.
>Because upstream zstd provides a CMake config file since nearly 2 years, so I thought that every system will have one. As far as I understand their "main" build system...
Fair enough :) -- OpenPGP key: 66DE F152 8299 0C21 99EF A801 A8A1 28A8 AB1C EE49
@Docteh I believe that if you make a copy the same _copy_-right year applies :)
I find the checked.png icon hard to look at with a white background. Would it be possible to darken its green a bit? Edit: also, the "wont totally fix #8077"...
The Noun Project offers icons licensed under the free [CC-BY-3.0 license](https://thenounproject.com/pricing/#icons). They feature a lot of icons, like [SD card icons](https://thenounproject.com/search/icons/?iconspage=1&q=SD%20card)