Andrea Pappacoda
Andrea Pappacoda
But MbedTLS 3.2 doesn't support SHA-3 yet, right? In that case, why not waiting for a release that includes SHA-3 support before the switch to the 3.x branch? That would...
Wouldn't it be better to use [`PROJECT_SOURCE_DIR`](https://cmake.org/cmake/help/latest/variable/PROJECT_SOURCE_DIR.html)? It always refers to the most recent `project()` call.
I think you forgot to commit the actual code changes - you've only updated the commit message :)
Oh ok @abouvier, I did not see it. Clean ups are a bit unrelated to unbundling dependencies though, do you think it makes sense to split these changes in these...
I had replied to this more than one hour ago via email, but for some reason GitHub dropped my reply... > * Alias of non-global imported library is only supported...
Oh, nice to know, thanks. CMake really is quirky...
> If you use both `pkg_search_module(lz4 ...)` and `find_package_handle_standard_args(lz4 ...` (same lowercase prefix), `pkg_search_module` will create the variable `lz4_VERSION` even if the package is not found (with empty value in...
> I guess that the variable listed in `VERSION_VAR` must be non existent if the library is not found. Here `opus_pc_VERSION` is still created with empty value. You should create...
As this looks to me like a CMake quirk and since it doesn't create actual issues to the build process, I'll avoid making the code more confusing just to work...
The CMake quick has been fixed: