Raffaele Bratta

Don't know if you're aware of it, but [this](https://marketplace.visualstudio.com/items?itemName=Wumpf.IncludeToolbox) is a brute force tool to clean useless `#include`. It basically tries to build a project/solution removing headers one by one...

> I don't know why you believe that. I don't know if our current formula is correct either. You're probably right I suspect. So... could you elaborate? :) [This](https://github.com/google/filament/blob/main/shaders/src/light_indirect.fs#L537) is...

Here you can see a comparison without (first image) and with (second image) the division by PI embedded in `kD` counteracted: ``` finalColour += pixelData.envColourD * pixelData.diffuse.xyz * 3.141592654 *...

[This](https://github.com/google/filament/blob/main/shaders/src/brdf.fs#L54) is how Filament computes GGX. Division by PI apart, I guess I'll get the same results removing `1e-6f` (please note that [`saturateMediump(x)` is defined as `x`](https://github.com/google/filament/blob/main/shaders/src/common_math.fs#L18) for non-mobile platforms).

> Regarding: > `float G = 0.5 / (( Lambda_GGXV + Lambda_GGXL + 1e-6f ) * 3.141592654);` I believe there is no such guarantee. > > If NdotL is 0,...

Apply this [patch](https://github.com/OGRECave/ogre-next/files/4097322/patch.txt) and launch _Sample_LocalCubemaps_ to see this PR in action :stuck_out_tongue_closed_eyes:!

Is there a reason why this PR has been closed "without a reason"?

> See https://stackoverflow.com/questions/24159036/how-to-modify-a-pull-request-on-github-to-change-target-branch-to-merge-into Seen it, but the dropdown to change target branch doesn't appear even on my side. As you said, probably because branch `v2-2-irradiance-field` doesn't exist anymore in the...

Hi @hartmutbehrens, Can you share your integrations of the various SMAA versions?

I'm in the same situation. Did anyone find a workaround for this issue?