ogre-next icon indicating copy to clipboard operation
ogre-next copied to clipboard

Spread cubemaps generation over multiple frames

Open TaaTT4 opened this issue 5 years ago • 6 comments

This PR aims to alleviate the cost of cubemaps generation spreading its workload over multiple frames (aka render just k faces of the cubemap per frames). See also: https://docs.unity3d.com/2020.1/Documentation/Manual/RefProbePerformance.html and https://forums.ogre3d.org/viewtopic.php?f=25&t=95409#p546658.

TaaTT4 avatar Dec 17 '19 18:12 TaaTT4

Apply this patch and launch Sample_LocalCubemaps to see this PR in action :stuck_out_tongue_closed_eyes:!

TaaTT4 avatar Jan 22 '20 12:01 TaaTT4

Is there a reason why this PR has been closed "without a reason"?

TaaTT4 avatar Apr 30 '20 05:04 TaaTT4

I think it got auto-closed when the target branch (v2-2-irradiance-field) ceased to exist.

The branch was unified into master. This PR was not meant to be closed.

Github is not letting me reopen it, and I can't see a way to change the target branch to master. But I'm going to sleep now so I didn't look much around the UI.

Cheers

darksylinc avatar Apr 30 '20 06:04 darksylinc

See https://stackoverflow.com/questions/24159036/how-to-modify-a-pull-request-on-github-to-change-target-branch-to-merge-into

darksylinc avatar Apr 30 '20 06:04 darksylinc

See https://stackoverflow.com/questions/24159036/how-to-modify-a-pull-request-on-github-to-change-target-branch-to-merge-into

Seen it, but the dropdown to change target branch doesn't appear even on my side. As you said, probably because branch v2-2-irradiance-field doesn't exist anymore in the remote. I'll try to do how do you would have done before GitHub introduced that feature.

TaaTT4 avatar Apr 30 '20 17:04 TaaTT4

Based on what you said, I managed to fix this: I added the branch back, reopened the PR, changed the target branch, then removed the branch again.

darksylinc avatar Apr 30 '20 18:04 darksylinc

Closing this PR because in OgreNext 3.0 it has become ridiculous simple to implement.

darksylinc avatar Jan 18 '23 14:01 darksylinc