Tomas Grosup

Results 530 comments of Tomas Grosup

Right now (AFAICS) the generation is driven by "doesSomething" at https://github.com/dotnet/fsharp/blob/main/src/Compiler/CodeGen/IlxGen.fs#L10241 The obviously bad thing is that a refactoring property of "moving modules around" is not stable. The same for...

I like the ModuleIntializerAttribute proposal for library code, leaning on the runtime to ensure an exactly-once execution. https://github.com/dotnet/runtime/blob/main/docs/design/specs/Ecma-335-Augments.md#module-initializer

The original suggestion did not have motivating examples where the existing F# features do not suffice and lead to unexpected (by the programmer) missed calls. This issue has it.

> * A code fix will only be useful for identifiers in patterns(where to make these lowercase) expect in match expression. So we will need to add a new error...

This was done as part of https://github.com/dotnet/fsharp/pull/16339 (it is in main, not yet in the released product) The following three syntax options of doing the same now work, does it...

Since this does affect the language, the new fallback branch should be guarded with a LanguageFeature flag. This will also need same extension of the https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/loops-for-to-expression section of the docs...

> > Since this does affect the language, the new fallback branch should be guarded with a LanguageFeature flag. > > It can also be a branch producing a recoverable...

What will the user experience when using `downto` to unsigned integral types? Is the message and range for it after this PR good enough? (existing integral `for .. to ..`...

To summarize: Lib 9, Consumer 8 -> this is the main scenario detected as being broken Lib 9, Consumer also 9 -> works Lib 8, Consumer 9 -> works And...

Hi @gusty , this is not fixed yet. I tried investigating it a few times, but so far not identified an approach for fixing that. It still remains a priority...