fslang-suggestions icon indicating copy to clipboard operation
fslang-suggestions copied to clipboard

Use of the `_.Property` shorthand in delegates

Open lucasteles opened this issue 2 years ago • 9 comments

I propose we enable to use of the new _.Property shorthand for accessor within Func<> and Expression<Func<>> as normal lambdas

["foo"; "42"; ""] |> List.map _.Length // [3; 2; 0]

open System.Linq
["foo"; "42"; ""].Select(_.Length) // fail

The existing way of approaching this problem in F# is:

Using normal lambdas

["foo"; "42"; ""].Select(fun s -> s.Length) 

Pros and Cons

The advantages of making this adjustment to F# are : make the syntax consistent

The disadvantages of making this adjustment to F# are : N/A

Extra information

Estimated cost (XS, S, M, L, XL, XXL):

Related suggestions: https://github.com/fsharp/fslang-suggestions/issues/506

Affidavit (please submit!)

Please tick these items by placing a cross in the box:

  • [x] This is not a question (e.g. like one you might ask on StackOverflow) and I have searched StackOverflow for discussions of this issue
  • [x] This is a language change and not purely a tooling change (e.g. compiler bug, editor support, warning/error messages, new warning, non-breaking optimisation) belonging to the compiler and tooling repository
  • [x] This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it
  • [x] I have searched both open and closed suggestions on this site and believe this is not a duplicate

Please tick all that apply:

  • [x] This is not a breaking change to the F# language design
  • [ ] I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the :+1: emoji on this issue. These counts are used to generally order the suggestions by engagement.

lucasteles avatar Aug 24 '23 14:08 lucasteles

cc @vzarytovskii

lucasteles avatar Aug 24 '23 14:08 lucasteles

["foo"; "42"; ""].Select(_.Length) :x: ["foo"; "42"; ""].Select _.Length ✔️

Happypig375 avatar Aug 24 '23 15:08 Happypig375

@Happypig375 I believe both should work, the first is important to not break the fluent chain

["foo"; "42"; ""].Select(_.Length).Where(isEven)

lucasteles avatar Aug 24 '23 16:08 lucasteles

@lucasteles only needed when there is a fluent chain.

Happypig375 avatar Aug 24 '23 16:08 Happypig375

This already has an issue: #506

Edit: Oh wait, is this specifically for Func/Expression?

cmeeren avatar Sep 04 '23 06:09 cmeeren

@cmeeren This is for any delegate, not F# function types.

Happypig375 avatar Sep 04 '23 12:09 Happypig375

Yes, then I definitely second this.

cmeeren avatar Dec 20 '23 17:12 cmeeren

This was done as part of https://github.com/dotnet/fsharp/pull/16339 (it is in main, not yet in the released product) The following three syntax options of doing the same now work, does it cover all of this suggestion?

open System.Linq
let _ = [""; ""; ""].Select(fun x -> x.Length)
let _ = [""; ""; ""].Select(_.Length)
let _ = [""; ""; ""].Select _.Length

T-Gro avatar Dec 20 '23 19:12 T-Gro

From what I can see, this would fix the issue, though I'm not the OP.

cmeeren avatar Dec 20 '23 20:12 cmeeren

Works like a charm (in main)!

image

abelbraaksma avatar May 16 '24 19:05 abelbraaksma