Tomas Grosup comments

Results 530 comments of


                                            Tomas Grosup

Allow implementation of generic methods with constraints of the form 'T :> 'U

I do not see GH having it, but maybe a self-assigning action after specific comment text could do it. /selfassign

No compiler error for instance members on static class; produces invalid IL & causes runtime error

Personally I would see it a lot cleaner to raise a 'dragons,beware'-style warning (not error because of backwards compat?) whenever [] is used. For any kind of newcomer, a module...

No compiler error for instance members on static class; produces invalid IL & causes runtime error

I meant an info/warning for [] any time it is used (instance properties or not). It does carry the feeling of an undocumented and unsupported scenario/hack.

Allow extension methods without type attribute.

LGTM , just the test failures need to get resolved

Allow extension methods without type attribute.

I am failing to see how the newly added code is connected with IAsyncDisposable, I do not see any connection at all. @vzarytovskii ; @KevinRansom : Have you ever seen...

Allow extension methods without type attribute.

I will try to check with what change this failure was introduced, still does not make any sense to me :((

Allow extension methods without type attribute.

My latest suspect is the error handling done in this method, with the call to **errorRecovery**. This produces a new diagnostical output, even though this method should very likely swallow...

Allow extension methods without type attribute.

This is what is falling trough: ``` FSharp.Compiler.DiagnosticsLogger+ReportedError: The exception has been reported. This internal exception should now be caught at an error recovery point on the stack. Original message:...

Allow extension methods without type attribute.

Btw. after the tests are working, I also want to have a look at some of code duplication within GetCSharpStyleIndexedExtensionMembersForTyconRef , seems somewhat doubled in there.

Remove unused FCS support for compiling from ASTs

Are both points approved to be removed? I would assume none of the (older) usages mentioned here are considered to be showstoppers as of today. And reducing the entry points...