Tomas Grosup

Results 528 comments of Tomas Grosup

I am a little puzzled by the motivation - I thought this attribute exists in order to access private fields via source code, i.e. when source generators (or similar mechanism)...

`extern functions don't support generic types` -> approved in principle, as said this is missing now and helps other legit use cases in native interop `extern functions have an extraneous...

Will see how long it takes before someone comes with an idea to build a .NET-language-fork that simply ignores all access modifiers in interop scenarios, desugaring such access into `UnsafeAccessor`...

Yes, long term code simplification should be the motivator here, since the rules were there but obsolete for many years. Old SDKs/nugets will continue to work if anyone wishes to...

> because of FSharp.Core conflicts Is it because of the changes this PR did? Right now I cannot see why the bootstrap process via build scripts should complain, but maybe...

The first error is legit - the error message is build up by the parsing state machine by the tokens which are allowed next. i.e. it is right that it...

Yep, sure. Done at https://github.com/dotnet/fsharp/pull/19149.

> Regarding release notes, should they really go in the files suggested in the first comment? Yes, this is correct. Compiler service API has changed, library has changed and language...

The wording is good, thanks for adding that 👍 . I am also thinking about building an unsupported (= not officially shipped) .vsix right before this change and uploading it...

IIRC the HostedCompiler was relying on stdout redirection, should only be used for some of the legacy test suites (FsharpQA I think). But FSharpQA still runs here, so that keeps...