Susucre

Results 123 comments of Susucre

I'll try to look into it. Hopefully this can be done without a big engine change. Those continuous effect affecting payment are weird (and lack clean UI to be used,...

Uhm so the setup of keys for setting the trigger count is not quite right: ![image](https://github.com/magefree/mage/assets/34709007/385a9b89-850e-45c3-a9e6-403e3f90f647) This is strange, because the comment on the CardUtil's method seems to indicate it...

Maybe the issue is with `getOriginalId()` instead of `getId()`? Not actually sure what is the purpose of `originalId` (that was already the setup before adding support for Nadu). And seems...

I would really appreciate some unit testing when adding such complex custom trigger. Doesn't need to be exhaustif but some ideas of tests: - Sacrifice a Desert - Sacrifice a...

[[Woodland Champion]] and [[Kambal, Profiteering Mayor]] have triggers that will also have bugs until the token creation are batched properly. Champion does trigger 3 times on [[Bestial Menace]] resolution (each...

I do not have the issue trying to replicate it ![image](https://github.com/magefree/mage/assets/34709007/df1f9cf0-d656-47ed-88af-869947c3bd17) Attempted to trade in combat too, no issue either: ![image](https://github.com/magefree/mage/assets/34709007/67424b32-30d2-43c3-9fa5-2a93d8be9cf1)

> I thought of another idea though for after this- what if we refactored Predicate interface to always be four argument match itself? Then we'd have only one type of...

So I'm not entirely sure the 2-argument match in FilterPermanent added with last commit is a good idea. It caused some tests to fail, that I fixed in that commit...

Source of the bug is that `CastFromHandSourcePermanentCondition` and `CastFromHandWatcher` only work on spell `UUID` and have no regard for zcc whatsoever.

Of note, cubes lists are often kept up to date on [Cubecobra](https://cubecobra.com) those days. Could add a way to create a cube tournament from a cubecobra url, importing a card...