Ben Kochie
Ben Kochie
@evevseev No ETA. IMO it's just easier to set `GOMAXPROCS=1` in your environment. Exporters typically need almost no CPU. So it's not a complicated thing that needs a lot of...
Nice. I think the only real issue is that this is a reasonably impactful behavior change. So we should probably put it behind a flag as to not surprise users.
@Spaceman1701 Yup, PagerDuty incidents is exactly the reason I raised this issue in the past.
@dependabot rebase
Getting that property should be reasonably easy to do in the systemd collector.
I created https://github.com/prometheus/node_exporter/pull/3111 as a draft. It doesn't work. I don't think the dbus API we have supports that generic call.
I agree, I'm not sure I see where the `log` collector struct field is used anywhere. I wonder if this is an old feature that has been refactored away.
Ahh, no, a few collectors use `c.log` for debug messages.
Yes, it would be nice to post a pprof profile and/or metrics to show the results of this change.
It's less about how many goroutines, but how much this impacts CPU and memory churn. For example, `rate(go_memstats_alloc_bytes_total[5m])` can show how much memory is being allocated. Less allocations, less GC,...