postgres_exporter icon indicating copy to clipboard operation
postgres_exporter copied to clipboard

Bugfix: Make sure all collectors have loggers

Open Sticksman opened this issue 2 years ago • 4 comments

I think this will make sure all loggers will also tell us when they got queried.

Sticksman avatar Jul 28 '23 22:07 Sticksman

@sysadmind @SuperQ

Sticksman avatar Jul 28 '23 22:07 Sticksman

I agree, I'm not sure I see where the log collector struct field is used anywhere. I wonder if this is an old feature that has been refactored away.

SuperQ avatar Sep 13 '23 13:09 SuperQ

Ahh, no, a few collectors use c.log for debug messages.

SuperQ avatar Sep 13 '23 13:09 SuperQ

Unless this PR is updated to include log messages when relevant, I don't think we need this PR. @Sticksman I will leave it up to you to decide if you want to add log messages or close the PR.

sysadmind avatar Sep 20 '23 01:09 sysadmind