Ben Kochie

Results 1558 comments of Ben Kochie

Yes, it seems like we're not recursing the aliased definition of DisplayString syntax.

I have released an update to the exporter-toolkit. (#1360)

The pprof endpoints are not configurable easily. We would have to custom register our own handlers. We basically need to completely re-work how we handle the web endpoint for exporters...

The GitHub UI creates a fork/branch, so you can check it out locally and use `git commit -s --amend` to update the DCO sign-off.

Configuration files are more safe than env vars. I recommend against doing this.

`FlagConfig` seems like a reasonable idea to me. What do you think @matthiasr?

Hmm, this seems like it's going to be toil heavy without something to sync the config between repos.

Incorporated suggestions.

We have a similar feature in the mysqld_exporter. It should be possible to implement similar features here.