postgres_exporter icon indicating copy to clipboard operation
postgres_exporter copied to clipboard

About adding query on pg_stat_statements.go

Open lunyi opened this issue 2 years ago • 1 comments

Proposal

Use case. Why is this important?

I saw the code https://github.com/prometheus-community/postgres_exporter/blob/master/collector/pg_stat_statements.go which return query_id.

The metrics are as below. pg_stat_statements_total_time_seconds{datname="my_database",queryid="-2096205478522934330",rolname="my_role",server="192.168.50.125:5432"} 2.5185217909999476 pg_stat_statements_total_time_seconds{datname="my_database",queryid="-4651997150931843586",rolname="my_role",server="192.168.50.125:5432"} 3.6924644360000562 pg_stat_statements_total_time_seconds{datname="my_database",queryid="-8454036462511310478",rolname="my_role",server="192.168.50.125:5432"} 9.827311363999982 pg_stat_statements_total_time_seconds{datname="my_database",queryid="-8775009150173006756",rolname="my_role",server="192.168.50.125:5432"} 4.998010090999978

We need to check which query string from query_id.

“Nice to have” is not a good use case. :)

Can we add query column in pg_stat_statements.go and show qurery in the metrics?

lunyi avatar Jun 15 '23 06:06 lunyi

We have a similar feature in the mysqld_exporter. It should be possible to implement similar features here.

SuperQ avatar Jun 15 '23 09:06 SuperQ