Ben Kochie

Results 1558 comments of Ben Kochie

@dswarbrick Thinking about cutting v2.0 asap.

We changed out the logging library to slog, while technically we don't have log formatting as part of the stability guarantees. I figured it was time. I actually wanted to...

I agree, we still need to clean up the tests so the Go modules dependencies are fixed.

It's up to the client_golang maintainers to cut a new release.

Oh, I see, this is to allow this. Wouldn't quotes used be a safer way to handle this?

@patrickeasters Thanks for digging into the quoting. Perhaps we should update the README docs to recommend backtick quoting of passwords.

I would also be fine with simply flipping `IgnoreInlineComment: true`.

This needs a DCO sign-off. You can use `git commit -s --amend` to add it.

I think this may already be possible with the various header and body sending and receiving field matching in the http probe.