Ben Kochie comments

Results 1558 comments of


                                            Ben Kochie

pkg/log: can we replace the built-in log with other log framework like logrus,zap.

No, using standard library logging is preferred to keep dependencies reduced. If we were to update the logging framework we should use the stdlib `log/slog`.

chore: Migrate more metrics to promauto

CC @ultrotter

Add "ignore_missing_values" option to metrics.

Thanks, this needs a rebase to handle the new logging interface.

Expose HTTPHost property in HTTPClientConfig

Ping @jkroepke @bboreham, any issues to resolve here?

[kube-prometheus-stack] Error on ingesting out-of-order samples only when scraping cAdvisor metrics

This very much seems like some kind of cAdvisor bug to me. Maybe an system time issue? It would be useful to get a data capture of the raw sample...

[kube-prometheus-stack] Error on ingesting out-of-order samples only when scraping cAdvisor metrics

# WARNING Warning to all those blindly setting intervals to 30s or disabling staleness tracking. **You are degrading the quality of the data in your system.** * **Removing timestamp staleness...

mountstats collector spams logs

That looks like the `mountstats` collector, not the `nfs` collector. There have been no changes to this collector since v1.8.2.

Update Go testing

:eyeglasses: @dormando

Update Go testing

I've also tried to be more conservative about bumping minimum versions. But the Go upstream only supports the latest 2 releases. So I typically recommend most libraries follow this policy....

Missing consoles and console_libraries files when installing Prometheus 3.0.0

This is an expected change. Prometheus no longer includes consoles in 3.0.