Parse BSS Load Information Elements
This change extends the parsing of the Information Elements to include the QBSS-Load Element
- BSS-Load parameters are included in a custom struct (with proper
String()Method) - Supports both Versions (same as Wireshark) - See
func decodeBSSLoad(b []byte) (*BSSLoad, error) - Includes the Following Parameters of the QBSS-Load:
- Station Count
- Channel Utilization
- Available Admission Capacity
Additionally the output of a failed test in TestIntegrationLinuxConcurrent has been extended.
The program was tested solely for our own use cases, which might differ from yours. Especially I only tested in WLAN-Networks with QBBS Load Version 2 (Wireshark calls this "802.11e CCA Version").
Lukas Raffelt < [email protected] > on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information
Licensed under MIT
Hey @SuperQ and @mdlayher , did you have any chance to look at this merge-request? Since this is my first contribution to this project, is there anything I am missing or can improve?
Or am I just too impatient? ;)
Cheers Lukas
One nice thing to do would be to squash your commits into logical changes. Rather than have a bunch of "Fix typo" changes.
Shall I do this right now (and invalidate the checks and so ...)? Or more as a general advice for my next pull request?
Yes, you can rebase/sqaush/change whenever you feel like.
Thanks for the input.
I will work on the suggestions later today and squash the commits to more sensible commits.
rebased on the current master.
Anything missing for a successful merge?
Hey @SuperQ any chance for the merge request to do through soon? Or do we still wait for the review from @mdlayher?
I'll leave it up to @SuperQ, I have not been actively participating in this library for some time.
Applied all suggestions, thanks for the feedback!
ah, sorry I thought everything was in the suggestions, will do it now
I have formatted the go Doc comments in my new Type BSSLoad similar to the suggested changes. I also harmonized the doc strings in type BSS.