wifi icon indicating copy to clipboard operation
wifi copied to clipboard

Parse BSS Load Information Elements

Open lukas-mbag opened this issue 2 years ago • 6 comments

This change extends the parsing of the Information Elements to include the QBSS-Load Element

  • BSS-Load parameters are included in a custom struct (with proper String() Method)
  • Supports both Versions (same as Wireshark) - See func decodeBSSLoad(b []byte) (*BSSLoad, error)
  • Includes the Following Parameters of the QBSS-Load:
    • Station Count
    • Channel Utilization
    • Available Admission Capacity

Additionally the output of a failed test in TestIntegrationLinuxConcurrent has been extended.

The program was tested solely for our own use cases, which might differ from yours. Especially I only tested in WLAN-Networks with QBBS Load Version 2 (Wireshark calls this "802.11e CCA Version").

Lukas Raffelt < [email protected] > on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information

Licensed under MIT

lukas-mbag avatar Dec 01 '23 14:12 lukas-mbag

Hey @SuperQ and @mdlayher , did you have any chance to look at this merge-request? Since this is my first contribution to this project, is there anything I am missing or can improve?

Or am I just too impatient? ;)

Cheers Lukas

lukas-mbag avatar Dec 08 '23 08:12 lukas-mbag

One nice thing to do would be to squash your commits into logical changes. Rather than have a bunch of "Fix typo" changes.

SuperQ avatar Dec 10 '23 13:12 SuperQ

Shall I do this right now (and invalidate the checks and so ...)? Or more as a general advice for my next pull request?

lukas-mbag avatar Dec 11 '23 10:12 lukas-mbag

Yes, you can rebase/sqaush/change whenever you feel like.

SuperQ avatar Dec 11 '23 10:12 SuperQ

Thanks for the input.

I will work on the suggestions later today and squash the commits to more sensible commits.

lukas-mbag avatar Dec 11 '23 12:12 lukas-mbag

rebased on the current master.

Anything missing for a successful merge?

lukas-mbag avatar Feb 07 '24 14:02 lukas-mbag

Hey @SuperQ any chance for the merge request to do through soon? Or do we still wait for the review from @mdlayher?

lukas-mbag avatar May 16 '24 11:05 lukas-mbag

I'll leave it up to @SuperQ, I have not been actively participating in this library for some time.

mdlayher avatar May 16 '24 16:05 mdlayher

Applied all suggestions, thanks for the feedback!

lukas-mbag avatar May 21 '24 08:05 lukas-mbag

ah, sorry I thought everything was in the suggestions, will do it now

lukas-mbag avatar May 21 '24 09:05 lukas-mbag

I have formatted the go Doc comments in my new Type BSSLoad similar to the suggested changes. I also harmonized the doc strings in type BSS.

lukas-mbag avatar May 21 '24 09:05 lukas-mbag