Ben Kochie

Results 1558 comments of Ben Kochie

This is actually a bug. It should probably be `p.proc.Path()`.

FYI, I have updated the Org shared secrets to included the required ENV vars for publishing.

This comes from the old `builtinMetricMaps` in `cmd/postgres_exporter/postgres_exporter.go`. This is on the TODO list to be migrated to the `collector` package. This will enable it to be > Due to...

This is something we want to tackle in the exporter-toolkit package. This way it's consistent across different exporters.

I'm actually trying to keep this, but we're going to move it to the exporter-toolkit package. This way the use is consistent across exporters.

I think we need you to rebase and squash your commit history here. There are now 16 commits in the PR history which is quite a mess.

There is https://github.com/prometheus-community/pgbouncer_exporter/pull/198, but the implementation needs work. I recommend looking at https://github.com/prometheus-community/postgres_exporter/pull/618 as the basis for an implementation.

FYI, this is already being done in https://github.com/prometheus-community/postgres_exporter/pull/1073

It looks like upstream Kubernetes forces Go minimum to be 1.24.0. This is of course a breaking change here because we support Go 1.23 while it is still supported by...