Steve Macenski comments

Results 2077 comments of


                                            Steve Macenski

including install space node, timeout for initial pose, and covariance defaults / configurable

That's true, but this PR has been dead for while anyhow. Not sure anyone is going to merge it but it implements the covariance variables

visualize frustum

@tonynajjar default ROS 2 linter profiles: ament_cpplint and ament_uncrustify

created clear area method to be able to properly clear spatio layer from the costmap

- Shouldn't there be a service or similar to access that method to clear? - If you look at how I populate the pointcloud for visualization, you can see how...

created clear area method to be able to properly clear spatio layer from the costmap

If you're OK not clearing out areas of the costmap, then the pseudo-code can definitely be removed. I always like to clear the full grid if there's a reason to...

created clear area method to be able to properly clear spatio layer from the costmap

I think you may have not pushed your code to GitHub, I haven't seen the update. Base implementation would deal with everything not-STVL. STVL you'd need to clear out the...

created clear area method to be able to properly clear spatio layer from the costmap

@MarcelSoler any updates? I'm willing to merge this as Part 1 of 2 part PRs if there's a recovery that will use this in part 2

created clear area method to be able to properly clear spatio layer from the costmap

No problem, just retarget the PR branch

created clear area method to be able to properly clear spatio layer from the costmap

[old old old....] hey there What are you using these days? If you're on melodic, we can just merge in melodic, Kinetic shouldnt be messed around with too much anyhow....

created clear area method to be able to properly clear spatio layer from the costmap

Ok. I will also push on @dlu to help get that over the line. That update is cleaner anyway. Are you looking to implement area based clearing to help with...

created clear area method to be able to properly clear spatio layer from the costmap

Wow, that was fast, its in navigation now.