Steve Dunn

Results 242 comments of Steve Dunn

Perhaps a trade off, at least for now, it to have an explicit parameter on the `ValueObjectAttribute`, something like `generateComparisonOperators`. Obviously, this will have to be on each Value Object...

But I think the crux of this issue is this: ![image](https://user-images.githubusercontent.com/263416/217063596-a66186a3-845b-4451-801f-039af7cb0947.png) But I don't think the warning makes much sense for generated code. For instance, for the case of GUIDs,...

> Another way to make the impact of this smaller is to solve #407 > > Some people do not need their Value Object to implement `IComparable` or its generic...

Oh no! Sorry about that. I'm not able to fix anything until next week. Perhaps clearing your intermediate files might help. Do you experience this in a new project?

@lk-smit-ag - glad it's now working (you had me worried there!) The operators aren't implemented; the implementation added merely allows types to omit the generation of `IComparable` (see #407 )

Hi @prlcutting—apologies for the *very* slow response—this thread is so long that I must've missed it originally. Thanks for the feedback, and I really appreciate that you like the library!...

Good idea @viceroypenguin . Thanks for the offer. There's a suppressor already that could be used as a reference point https://github.com/SteveDunn/Vogen/blob/main/src/Vogen/Suppressors/CA1822DecoratedMethodSuppressor.cs

I found and fixed [a bug in Roslyn ](https://github.com/dotnet/roslyn/issues/74117) that stops us from using this. Revisit in the future.

Hi - sorry for the delay in replying. Very happy to accept any contributions. It would be great to enable everyone to use Vogen in Orleans while still having all...

I'm not trying to poach users from this great tool, but Vogen now generates ERCore converters in a separate assembly. Vogen is aimed more at value objects than IDs, but...