Steve Dunn

Results 242 comments of Steve Dunn

Thank you very @CeSiumUA ! Awfully sorry about the *extremely* slow response! I was just clearing out my inbox and found an e-mail re. this notification from 6 months ago!...

Hi, I don't normally do PRs on here, so forgive me for breaking the build. It was expected though, as I upped the version number of Blazor to 3.1.1 and...

Hi @dzmitry-lahoda - visiting some old comments now that I've got a bit of time free. Do you mean to make the generated code `IValidatableObject`?

Good idea! Vogen doesn't current support these as everything implements `IEquatable`. But it should support them. We'll need to add constraints that ref structs can't have any 'conversions' (`TypeConverter`, Dapper,...

I'm still looking at this one, although I haven't been able to find a suitable bit of code that I can benchmark (in benchmark.net) that demonstrates any speed increase.

> I'm still looking at this one, although I haven't been able to find a suitable bit of code that I can benchmark (in benchmark.net) that demonstrates any speed increase....

By having the generator generate an empty partial method in the generated code, It would other code analyzers, such as resharper, reporting things like this: ![image](https://user-images.githubusercontent.com/263416/168461503-ae51bf0e-8ed0-48bd-a4d8-2098b0f9f218.png)

Thanks @SubhajitS - let me know if you need any help. Thanks also @dzmitry-lahoda . I'm thinking - is it worth just removing `readonly` from Value altogether and not even...

@dzmitry-lahoda - is your main concern the defensive copies? The `Value` field is `get` only so there won't be any defensive copies. One of my goals is to keep the...

@SubhajitS - I'm having second thoughts on this one. I've asked on runtime discord server, and there isn't any perf overhead. Would like to be proven wrong though...