Stephan Schroevers
Stephan Schroevers
As of this release the `error_prone_core` artifact [pulls in](https://github.com/google/error-prone/blob/b7e2cd7b37fe9a29b0508ad84998e366f3fdb921/core/pom.xml#L365-L369) `javax.inject`, so IIUC i.c.w. Error Prone 2.18.0 the dependency could be declared `provided`. (I think that'd also work with older versions...
Rebased and resolved conflict: these days we use the MongoDB driver BOM.
I would have expected an Error Prone incompatibility, but in fact it's an OpenRewrite incompatibility :sweat_smile:. @timtebeek FYI: ``` Caused by: java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.DCTree$DCDocComment com.sun.tools.javac.tree.DocCommentTable.getCommentTree(com.sun.tools.javac.tree.JCTree)' at org.openrewrite.java.isolated.ReloadableJava11ParserVisitor.convert(ReloadableJava11ParserVisitor.java:1590) ``` JDK 23 will...
> As an aside you might want to change these lines to use rewrite-java-17, or a version matching the runtime Java version, as you're right now getting an error from...
Updated the PR; build should pass once openrewrite/rewrite#4618 is released.
Nice! I expect Renovate to open the upgrade PR tonight. :new_moon_with_face:
> Nice! I expect Renovate to open the upgrade PR tonight. 🌚 Nope, cause we pull it in via `rewrite-recipe-bom`, for which no release happened yet. For now I added...
I don't _think_ we're planning a release soon, so no rush! I had a quick look myself; @knutwannheden @MBoegers I'm a bit surprised to see that the [BOM diff](https://github.com/openrewrite/rewrite-recipe-bom/compare/v3.2.0...v3.3.0) is...
@MBoegers thanks for the rapid response, but please don't spend your weekend on this; we have no release plans. :pray: Have a great weekend!
> So if I understand the above correctly then adding rewrite-java-21 would also fix this issue. It would, but that would require that we stop support for building with Java...